Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): Mark TestConnectionDatabaseCommand as non-test related #29366

Merged
merged 1 commit into from
Jun 26, 2024
Merged

chore(tests): Mark TestConnectionDatabaseCommand as non-test related #29366

merged 1 commit into from
Jun 26, 2024

Conversation

john-bodley
Copy link
Member

SUMMARY

Addresses the following warning whilst running pytest,

cannot collect test class 'TestConnectionDatabaseCommand' because it has a __init__ constructor (from: ...)

via the suggestion here.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley marked this pull request as ready for review June 25, 2024 22:52
@john-bodley john-bodley merged commit 731cfb1 into master Jun 26, 2024
58 of 59 checks passed
@john-bodley john-bodley deleted the john-bodley--test-connection-ignore-whilst-testing branch June 26, 2024 19:01
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@john-bodley @eschutho
chore(tests): Mark TestConnectionDatabaseCommand as non-test related (#…
55dbc3c 
…29366)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-bodley @rusackas @mistercrunch