Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(readme): changing video from mp4 to webm format #29392

Merged
merged 5 commits into from
Jun 27, 2024
Merged

fix(readme): changing video from mp4 to webm format #29392

merged 5 commits into from
Jun 27, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

The video wasn't/isn't playing. Someone on Stack Overflow says this'll fix it. Let's see!!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the doc Namespace | Anything related to documentation label Jun 27, 2024
rusackas
rusackas commented Jun 27, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the doc Namespace | Anything related to documentation label Jun 27, 2024
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Jun 27, 2024
@rusackas rusackas merged commit c70a9d0 into master Jun 27, 2024
34 checks passed
@rusackas rusackas deleted the webm_video branch June 27, 2024 17:31
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Jul 1, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@rusackas @eschutho
fix(readme): changing video from mp4 to webm format (#29392)
771b31d
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rusackas @john-bodley @mistercrunch @michael-s-molina