Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(frontend): remove obsolete ESLint rules in tests #29405

Merged
merged 2 commits into from
Jun 28, 2024
Merged

chore(frontend): remove obsolete ESLint rules in tests #29405

merged 2 commits into from
Jun 28, 2024

Conversation

hainenber
Copy link
Contributor

chore(frontend): remove obsolete ESLint rules

SUMMARY

Remove obsolete no-unused-expression ESLint rule in superset-frontend tests

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

hainenber added 2 commits June 28, 2024 22:49
@hainenber
chore(frontend): remove obsolete ESLint rules
3139a97 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
chore(frontend): remove obsolete ESLint rule for remaining tests
8c1c260 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@mistercrunch
Copy link
Member

Thanks for the PR!

@mistercrunch mistercrunch merged commit e274925 into apache:master Jun 28, 2024
35 of 36 checks passed
@hainenber hainenber deleted the remove-obsolete-eslint-rules branch June 29, 2024 02:24
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@hainenber @eschutho
chore(frontend): remove obsolete ESLint rules in tests (#29405)
ef1d47c 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hainenber @mistercrunch