fix: catalog permission check

[betodealmeida]

SUMMARY

Fix a couple issues with the catalog permission check when adding a dataset:

• When listing catalogs there is an off-by-one error when including catalogs in which the user has schema access. For example, if a database db has 2 catalogs, A and B, if the user has access to the schema db.A.schema1 we should show catalog A in the response from get_catalogs_accessible_by_user. The off by one error makes the method return schema1 instead, which is then discarded because it is not in {A, B}.
• When fetching tables, if a catalog is not specified (either because "Allow changing catalogs" is disabled, or because the DB doesn't support catalogs) then the schema permission still needs to be built with catalog or default_catalog, since we need the catalog name in the built schema permission even if "Allow changing catalogs" is disabled, otherwise the schema check will fail.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

WIP

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[betodealmeida]

There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors.