Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Required native filter message wrongfully appearing #29643

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: Required native filter message wrongfully appearing #29643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 25 additions & 23 deletions superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,31 +675,33 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
editMode={editMode}
marginLeft={dashboardContentMarginLeft}
>
{missingInitialFilters.length > 0 ? (
<div
css={css`
display: flex;
flex-direction: row;
align-items: center;
justify-content: center;
flex: 1;
& div {
width: 500px;
}
`}
>
<BasicErrorAlert
title={t('Unable to load dashboard')}
body={t(
`The following filters have the 'Select first filter value by default'
{showDashboard ? (
missingInitialFilters.length > 0 ? (
<div
css={css`
display: flex;
flex-direction: row;
align-items: center;
justify-content: center;
flex: 1;
& div {
width: 500px;
}
`}
>
<BasicErrorAlert
title={t('Unable to load dashboard')}
body={t(
`The following filters have the 'Select first filter value by default'
option checked and could not be loaded, which is preventing the dashboard
from rendering: %s`,
missingInitialFilters.join(', '),
)}
/>
</div>
) : showDashboard ? (
<DashboardContainer topLevelTabs={topLevelTabs} />
missingInitialFilters.join(', '),
)}
/>
</div>
) : (
<DashboardContainer topLevelTabs={topLevelTabs} />
)
) : (
<Loading />
)}
Expand Down
Loading