refactor(ProgressBar): Upgrade ProgressBar to Antd 5 #29666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,6 +64,11 @@ const baseConfig: ThemeConfig = { | |||
| borderRadiusSM: supersetTheme.gridUnit / 2, | |||
| defaultBg: supersetTheme.colors.grayscale.light4, | |||
| }, | |||
| Progress: { | |||
| fontSize: supersetTheme.typography.sizes.s, | |||
There was a problem hiding this comment.
@geido Is it possible to specify these at the component?
There was a problem hiding this comment.
This was a decision we made to keep the style centralized rather than scattered across. The component tokens are relevant to general theme, as the general theme might need to be tweaked if we realize that multiple components are using the same styles and thus should be promoted. We can reconsider this choice once the big part of the transition is done and the general theme should be stable.
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
|
@supersetbot label 4.1 |
github-actions
bot
added
the
v4.1
sadpandajoe
pushed a commit
that referenced
this pull request
Aug 13, 2024
(cherry picked from commit 3de2b7c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Please refer to the Superset Improvement Proposal #29268
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION