Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(translations): Translate embedded errors #29782

Merged
merged 4 commits into from
Jul 31, 2024
Merged

fix(translations): Translate embedded errors #29782

merged 4 commits into from
Jul 31, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

Fixes #27426

Adds a translated string for an embedded error display.

Creates a new .pot extract with this string, since we should be doing this regularly anyway!

Adds explicit sorting of msgids using msgcat for that .pot file

Adds new .po files generated from the .pot.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from mistercrunch July 30, 2024 23:30
@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:spanish Translation related to Spanish language i18n:italian Translation related to Italian language i18n:french Translation related to French language i18n:chinese Translation related to Chinese language i18n:japanese Translation related to Japanese language i18n:russian Translation related to Russian language i18n:korean Translation related to Korean language i18n:dutch i18n:slovak i18n:ukrainian i18n:portuguese i18n:brazilian i18n:traditional-chinese labels Jul 30, 2024
@rusackas rusackas changed the title Translate embedded error fix(translations): Translate embedded errors Jul 30, 2024
This was referenced Jul 30, 2024
Closed
Closed
@rusackas rusackas requested a review from villebro July 31, 2024 00:05
@rusackas rusackas merged commit 0d62bb2 into master Jul 31, 2024
35 of 36 checks passed
@rusackas rusackas deleted the translate-embedded-error branch July 31, 2024 17:19
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Aug 1, 2024
@rusackas @sadpandajoe
fix(translations): Translate embedded errors (apache#29782)
d0ae713 
(cherry picked from commit 0d62bb2)
@OmarIthawi OmarIthawi mentioned this pull request Aug 3, 2024
Merged
9 tasks
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 13, 2024
sadpandajoe pushed a commit that referenced this pull request Nov 13, 2024
@rusackas @sadpandajoe
fix(translations): Translate embedded errors (#29782)
66fe0b0 
(cherry picked from commit 0d62bb2)
@mistercrunch mistercrunch added 🍒 4.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 27, 2024
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
@rusackas @sadpandajoe
fix(translations): Translate embedded errors (#29782)
becca2f 
(cherry picked from commit 0d62bb2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n:brazilian i18n:chinese Translation related to Chinese language i18n:dutch i18n:french Translation related to French language i18n:italian Translation related to Italian language i18n:japanese Translation related to Japanese language i18n:korean Translation related to Korean language i18n:portuguese i18n:russian Translation related to Russian language i18n:slovak i18n:spanish Translation related to Spanish language i18n:traditional-chinese i18n:ukrainian i18n Namespace | Anything related to localization preset-io size/XXL v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedded dashboard error is always in English
4 participants
@rusackas @michael-s-molina @mistercrunch @sadpandajoe