Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ace-builds
was 1 of the largest libraries in our bundle. It was always fetched when opening a dashboard even though it's only used in dashboard's edit mode (if there are markdown components), SQL lab, and SQL Editor popover in Explore.This PR implements lazy loading that library.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Notice that we no longer fetch a 1.3MB chunk when opening a dashboard
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION