fix(migrations): Fix the time comparison migration

[Antonio-RiveroMartnez]

SUMMARY

After the initial version of the time comparison feature for Table and Big Number we introduced a migration to upgrade old charts to the new comparison controls, however, during that upgrade a table that never had comparison in it was wrongly showing Time Comparison Data.

This PR is fixing the migration so we can properly upgrade such old tables if needed, also we extend our tests to not only consider charts that have the enabled_time_comparison flag set to True.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Old version of Chart using Time Comparison once but then removing it from the controls:

The old Chart is upgraded with the previous version of the migration:

The chart start showing comparison data:

AFTER

Old version of Chart using Time Comparison once but then removing it from the controls:

The old Chart is upgraded with the new version of the migration:

The chart doesn't show comparison data:

TESTING INSTRUCTIONS

1. Create a table chart with a version of the time comparison where Enable Time Comparison checkbox was used
2. Run a comparison data (Mark the checkbox and select a time range)
3. Unmark the checkbox and run the chart data again so your chart has no longer comparison info
4. Use more updated version and run the migrations so your table is upgraded
5. You must not see time comparison data in the table.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (76d897e) to head (e349e28).
Report is 637 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #30029       +/-   ##
===========================================
+ Coverage   60.48%   83.68%   +23.20%     
===========================================
  Files        1931      528     -1403     
  Lines       76236    38207    -38029     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31975    -14139     
+ Misses      28017     6232    -21785     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.92% <ø> (-0.24%)	⬇️
javascript	?
mysql	76.77% <ø> (?)
postgres	76.84% <ø> (?)
presto	53.48% <ø> (-0.32%)	⬇️
python	83.68% <ø> (+20.20%)	⬆️
sqlite	76.31% <ø> (?)
unit	60.29% <ø> (+2.66%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[betodealmeida]

Thanks for fixing this!

[michael-s-molina]

Would you mind extracting the common parts between params_v1_with_custom, params_v1_other_than_custom_false, params_v2_with_custom, params_v2_other_than_custom, params_v2_other_than_custom_false and just override the necessary properties for each variable to avoid code duplication and increase readability?

[michael-s-molina]

Thanks for addressing the comments @Antonio-RiveroMartnez!