fix: Handle zstd encoding in webpack proxy config

[kgabryje]

SUMMARY

Some of the latest changes caused the localhost:9000 to use zstd encoding, which we didn't handle in webpack.proxy-config.js. This PR adds simple-zstd lib to decompress zstd encoded data.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Run npm run dev-server, go to localhost:9000, verify that it works normally

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[michael-s-molina]

THANK YOU!

[villebro]

Also big thanks from me! I'd be curious to understand what caused this regression..

[rusackas]

Closing #29822 as superseded by this one.

[mistercrunch]

@kgabryje shouldn't this be in devDependencies?

[kgabryje]

It should, I moved it to dependencies to silence eslint errors. It shouldn't really affect the entry point sizes though, as webpack will put this package in a chunk that's not downloaded on any page

[mistercrunch]

Having issues on master RN, saying zstd not installed. Though npmjs.org seems to be having issues, with npm ci --verbose stalling for minutes at a time...

In docker-compose up

superset_node         | [webpack-cli] Failed to load '/app/superset-frontend/webpack.config.js' config
superset_node         | [webpack-cli] Error: Can not access zstd! Is it installed?

[kgabryje]

Having issues on master RN, saying zstd not installed. Though npmjs.org seems to be having issues, with npm ci --verbose stalling for minutes at a time...

In docker-compose up

superset_node         | [webpack-cli] Failed to load '/app/superset-frontend/webpack.config.js' config
superset_node         | [webpack-cli] Error: Can not access zstd! Is it installed?

I put apt-get install zstd in Dockerfile and it works on CI build. Do you have an idea why it's not available in docker compose?

[mistercrunch]

I don't understand why it's not installed while it's specified here https://github.com/apache/superset/blob/master/Dockerfile#L35, debugging RN and had a test.js in the docker, didn't work, ran apt-get install zstd while in the container and it worked after. Very confusing.

[kgabryje]

I don't understand why it's not installed while it's specified here https://github.com/apache/superset/blob/master/Dockerfile#L35, debugging RN and had a test.js in the docker, didn't work, ran apt-get install zstd while in the container and it worked after. Very confusing.

Is it possible that docker compose skips the part where we install zstd in existing containers?

[mistercrunch]

idk - was messing around with it and now exact same SHA command and now magically works, feels like there was a corrupt binary somewhere at Debian and now it's fixed.

[MialLewis]

idk - was messing around with it and now exact same SHA command and now magically works, feels like there was a corrupt binary somewhere at Debian and now it's fixed.

This is happening to me... any idea what the magic fix could have been?

I've tried nuking all existing and cached containers.

[MialLewis]

I managed to "fix" it by hacking in "dev": "apt-get update && apt-get install zstd && webpack --mode=development --color --watch"

here: https://github.com/apache/superset/blob/master/superset-frontend/package.json#L49

[mistercrunch]

Really shouldn't be problem, wondering if nuking docker caches and docker compose build should get you back on your feet.