Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): skip extremely flaky gaq test #30072

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

villebro
Copy link
Member

@villebro villebro commented Aug 30, 2024

SUMMARY

The test_chart_data_async has been disabled, then re-enabled in the hopes that the new sleeps would fix it. This was not the case, and it's causing a lot of headache for getting CI green on PRs. I'm disabling it for now, and these will all likely be rewritten soon as part of SIP-134.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.53%. Comparing base (76d897e) to head (dfa0d2a).
Report is 655 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30072       +/-   ##
===========================================
+ Coverage   60.48%   70.53%   +10.04%     
===========================================
  Files        1931     1975       +44     
  Lines       76236    79425     +3189     
  Branches     8568     9043      +475     
===========================================
+ Hits        46114    56024     +9910     
+ Misses      28017    21175     -6842     
- Partials     2105     2226      +121     
Flag Coverage Δ
hive 48.91% <ø> (-0.26%) ⬇️
javascript 58.35% <ø> (+0.64%) ⬆️
mysql 76.69% <ø> (?)
postgres 76.79% <ø> (?)
presto 53.47% <ø> (-0.34%) ⬇️
python 83.63% <ø> (+20.15%) ⬆️
sqlite 76.25% <ø> (?)
unit 60.25% <ø> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@giftig giftig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding sleeps aren't a good solution to getting a flaky test working so I agree let's just disable it until we have a real solution, it seems like it's causing more harm than good.

Given how much you're struggling with the cypress tests as well I'd disable that one while you're here too.

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Sep 3, 2024
@villebro villebro force-pushed the villebro/remove-flaky-gaq-test branch from 718b793 to dfa0d2a Compare September 3, 2024 18:05
@mistercrunch mistercrunch marked this pull request as draft September 4, 2024 01:19
@mistercrunch
Copy link
Member

Makes sense, converted to draft, feel free to reflag for review if you want to push this one through

@villebro villebro force-pushed the villebro/remove-flaky-gaq-test branch from dfa0d2a to 3d7ff5d Compare September 4, 2024 04:57
@github-actions github-actions bot removed the github_actions Pull requests that update GitHub Actions code label Sep 4, 2024
@villebro villebro marked this pull request as ready for review September 4, 2024 18:37
@villebro villebro merged commit d406c80 into apache:master Sep 4, 2024
96 of 98 checks passed
@villebro villebro deleted the villebro/remove-flaky-gaq-test branch September 4, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants