Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Retrieving Slack channels when Slack is disabled #30074

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: Retrieving Slack channels when Slack is disabled #30074

merged 1 commit into from
Sep 3, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #30026

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the alert-reports Namespace | Anything related to the Alert & Reports feature label Aug 30, 2024
villebro
villebro approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 72a520f into apache:master Sep 3, 2024
36 of 37 checks passed
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 3, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 3, 2024
@michael-s-molina @sadpandajoe
fix: Retrieving Slack channels when Slack is disabled (#30074)
b4068f1 
(cherry picked from commit 72a520f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@eschutho eschutho Awaiting requested review from eschutho

@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe

Assignees
No one assigned
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET /api/v1/report/slack_channels is being called with ALERT_REPORT_SLACK_V2 off
3 participants
@michael-s-molina @villebro @sadpandajoe