Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixing missing 'c' in installation guide documentation #30127

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

JordanTB
Copy link
Contributor

@JordanTB JordanTB commented Sep 2, 2024

Fixed missing 'c' in 'docker-compose'

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Fixed missing 'c' in 'docker-compose'
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Sep 2, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should actually be docker compose, would you mind removing the hyphen? This was introduced accidentally in #30030

@sfirke
Copy link
Member

sfirke commented Sep 3, 2024

Oh and the failing check says you should edit your PR title:

Error: Please format your PR title to match: ^(build|chore|ci|docs|feat|fix|perf|refactor|style|test|other)(\(.+\))?(\!)?:\s.+!

See https://www.conventionalcommits.org/en/v1.0.0/

@michael-s-molina michael-s-molina changed the title Fixing missing 'c' in installation guide documentation docs: Fixing missing 'c' in installation guide documentation Sep 3, 2024
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@rusackas rusackas merged commit 3f2e237 into apache:master Sep 4, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants