Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New tooltip inappropriately combines series on mixed chart #30137

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: New tooltip inappropriately combines series on mixed chart #30137

merged 1 commit into from
Sep 4, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #30136

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-09-03 at 13 42 17 Screenshot 2024-09-03 at 13 45 05

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added viz:charts:echarts Related to Echarts viz:charts:tooltip Related to tooltips in charts labels Sep 3, 2024
sfirke
sfirke approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a speedy fix, thank you!

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Sep 3, 2024
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 3, 2024
@rusackas
Copy link
Member

rusackas commented Sep 3, 2024

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

@rusackas Ephemeral environment spinning up at http://52.12.113.143:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina michael-s-molina merged commit 9cb9e5b into apache:master Sep 4, 2024
37 of 38 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Ephemeral environment shutdown and build artifacts deleted.

@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Sep 4, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 4, 2024
@michael-s-molina @sadpandajoe
fix: New tooltip inappropriately combines series on mixed chart (#30137)
1d90ee3 
(cherry picked from commit 9cb9e5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfirke sfirke sfirke approved these changes

@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe

Assignees
No one assigned
Labels
plugins size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch viz:charts:echarts Related to Echarts viz:charts:tooltip Related to tooltips in charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New tooltip in 4.1.0+ is inappropriately combines series on mixed chart with two y-axes
4 participants
@michael-s-molina @rusackas @sfirke @sadpandajoe