Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): Table Schema View with no catalog #30139

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

Some tables might not have catalogs when hitting the tableschemaview endpoint, so the View must handle that instead of assuming the dict always has the catalog key.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2024-09-03.at.8.22.08.PM.mov

After:

Screen.Recording.2024-09-03.at.8.23.23.PM.mov

TESTING INSTRUCTIONS

  1. connect a google sheet to be used as a database
  2. go to sql lab
  3. select your database
  4. select your schema
  5. select your table
  6. Your table must load the preview

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the sqllab Namespace | Anything related to the SQL Lab label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (76d897e) to head (8cafbbe).
Report is 662 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30139       +/-   ##
===========================================
+ Coverage   60.48%   83.64%   +23.15%     
===========================================
  Files        1931      529     -1402     
  Lines       76236    38268    -37968     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32009    -14105     
+ Misses      28017     6259    -21758     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.91% <ø> (-0.26%) ⬇️
javascript ?
mysql 76.73% <ø> (?)
postgres 76.80% <ø> (?)
presto 53.49% <ø> (-0.31%) ⬇️
python 83.64% <ø> (+20.15%) ⬆️
sqlite 76.27% <ø> (?)
unit 60.25% <ø> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 3, 2024
@Antonio-RiveroMartnez Antonio-RiveroMartnez merged commit 6009023 into apache:master Sep 4, 2024
40 of 41 checks passed
sadpandajoe pushed a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS sqllab Namespace | Anything related to the SQL Lab v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants