Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adds the Deprecated label to Time-series Percent Change chart #30148

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: Adds the Deprecated label to Time-series Percent Change chart #30148

merged 1 commit into from
Sep 4, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

The Time-series Percent Change chart description says it's a deprecated chart but it was missing the Deprecated label. This PR adds the label.

Fixes #29711

TESTING INSTRUCTIONS

Check that the label is present.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts:timeseries Related to Timeseries label Sep 4, 2024
@michael-s-molina michael-s-molina merged commit 5e42d7a into apache:master Sep 4, 2024
35 of 36 checks passed
@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe

Assignees
No one assigned
Labels
plugins size/XS viz:charts:timeseries Related to Timeseries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The description of a chart indicate "deprecated" but the graphical tag is not present
2 participants
@michael-s-molina @mistercrunch