fix: Disable cross filtering on charts with no dimensions #30176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Cross filtering feature is designed to apply filters based on a dimension that user clicked in the source chart.
In some chart plugins, when the chart has no dimensions (only metric series), click on a metric would emit an empty cross filter, providing confusing user experience.
This PR disables cross filtering on charts that have no dimensions set.
Additionally, some charts were marked as compatible with cross filtering feature (
behaviors: [Behavior.InteractiveChart]
), but were in fact not implementing the feature. In those charts I removed the behavior and added aTODO
comment to implement cross filtering.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION