Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Embedded): Dashboard screenshot should use GuestUser #30200

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(Embedded): Dashboard screenshot should use GuestUser #30200

merged 1 commit into from
Sep 10, 2024

Conversation

geido
Copy link
Member

@geido geido commented Sep 9, 2024

SUMMARY

The dashboard screenshot endpoint would fail when used from an Embedded Dashboard as the find_user method would not find the user. This PR introduces a check so that the executor will always be the GuestUser when the request fires from an Embedded Dashboard,

TESTING INSTRUCTIONS

  1. Visit an Embedded Dashboard
  2. Generate a screenshot of the Dashboard
  3. The screenshot should be downloaded successfully

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Sep 9, 2024
@dosubot dosubot bot added dashboard:security:access Related to the security access of the Dashboard embedded labels Sep 9, 2024
mistercrunch
mistercrunch approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 9, 2024
@geido geido merged commit 52a03f1 into master Sep 10, 2024
35 of 36 checks passed
@geido geido mentioned this pull request Sep 10, 2024
Merged
9 tasks
sadpandajoe pushed a commit that referenced this pull request Sep 11, 2024
@geido @sadpandajoe
fix(Embedded): Dashboard screenshot should use GuestUser (#30200)
6205fb4 
(cherry picked from commit 52a03f1)
@rusackas rusackas deleted the geido/fix/embedded-dash-screenshot branch September 27, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
api Related to the REST API dashboard:security:access Related to the security access of the Dashboard embedded size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geido @mistercrunch @sadpandajoe