chore: organize SQL parsing files #30258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
organize-sql-files
branch
2 times, most recently
from
63813b1
to
163feb4
Compare
betodealmeida
force-pushed
the
organize-sql-files
branch
from
163feb4
to
58384de
Compare
eschutho
reviewed
Sep 12, 2024
| @@ -63,7 +63,8 @@ | |||
| from superset.databases.utils import get_table_metadata, make_url_safe | |||
| from superset.errors import ErrorLevel, SupersetError, SupersetErrorType | |||
| from superset.exceptions import DisallowedSQLFunction, OAuth2Error, OAuth2RedirectError | |||
| from superset.sql_parse import ParsedQuery, SQLScript, Table | |||
| from superset.sql.parse import SQLScript, Table | |||
| from superset.sql_parse import ParsedQuery | |||
There was a problem hiding this comment.
nit, but these two paths are really similar. What's the difference between them and will people be able to remember what goes where?
There was a problem hiding this comment.
Oh, sorry, I forgot to mention that the goal is to get rid of sql_parse.py.
The new superset/sql/ directory will use only sqlglot, and as I'm working on SIP-117 I'm taking sqlparse logic from sql_parse.py and reimplementing it using sqlglot in sql/parse/.
There was a problem hiding this comment.
ok, perfect, that makes sense, then.
eschutho
approved these changes
Sep 12, 2024
sadpandajoe
added
the
v4.1
sadpandajoe
pushed a commit
that referenced
this pull request
Sep 30, 2024
(cherry picked from commit bdf29cb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Move the
SQLScript,SQLStatement, and related functions that usesqlglotto a new directorysuperset/sql/, since thesuperset/sql_parse.pyfile is getting big. This was suggested by @mistercrunch on the discussion about SIP-117.The goal with SIP-117 is to have all SQL parsing living in
superset/sql/and usingsqlglot, and get rid ofsql_parse.py.I also split the unit tests from
tests/unit_tests/sql_parse_tests.pytotests/unit_tests/sql/parse_tests.py, and in the process I converted some of the oldParsedQuery.tablestests to the newextract_tables_from_statementfunction.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION