Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cypress to v 11 #30262

Merged
merged 2 commits into from
Sep 19, 2024
Merged

chore: bump cypress to v 11 #30262

merged 2 commits into from
Sep 19, 2024

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Sep 12, 2024

SUMMARY

Per the cypress docs, this experimental flag should help with some of the chromium memory problems we've been seeing, but it needs at least v12 in order to do anything:
https://docs.cypress.io/guides/references/error-messages#The-Chromium-Renderer-process-just-crashed

Bumping this version to 11. We'll do 12 in a separate PR

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's hope this fixes that flaky test! One comment on the removed config.

requestTimeout: 10000,
video: false,
videoUploadOnPasses: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this removal intentional? I don't see it mentioned in the docs or the description..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was flagged by typescript that it no longer exists.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, that explains why it wasn't mentioned in the docs 😄

@eschutho
Copy link
Member Author

eschutho commented Sep 12, 2024

I checked to see if we had tried this flag before, and sure enough @rusackas had a PR that enabled it, and then removed it because it wasn't supported in v10. (they added support in v12). So I'm trying my luck to see how easily I can bump to 12. 🤞

@eschutho eschutho changed the title fix:add memory management to cypress config chore: bump cypress to v 12 Sep 12, 2024
@eschutho eschutho changed the title chore: bump cypress to v 12 chore: bump cypress to v 11 Sep 13, 2024
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this ❤️

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a way to upgrade with a GUI using npx if you're not already aware. I've been curious how well that works, maybe it'll be helpful for the next bumps.

@rusackas
Copy link
Member

@eschutho eschutho merged commit a90aa05 into master Sep 19, 2024
37 checks passed
@eschutho
Copy link
Member Author

I think there's a way to upgrade with a GUI using npx if you're not already aware. I've been curious how well that works, maybe it'll be helpful for the next bumps.

Oh nice. I'll try that. There's also a PR already where someone did the difficult work of bumping to v13. I was thinking of reviving that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants