-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(legacy-plugin-chart-map-box): bump supercluster to v8 #30305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/testenv up |
@birkskyum to test/review these PRs, we typically need to check the plugin. There are a few ways to do this:
I'll start with #1 here before I approve. @mistercrunch was your review a code review, or did you test/validate the upgrade? |
I only reviewed the 3 lines, seemed benign, didn't test locally |
Tested, works great! Thanks, @birkskyum! |
No idea why ephemeral environments aren't working again. Any ideas, @mistercrunch? Did those move to supersetbot or something? |
SUMMARY
Part of:
Modernizing the legacy-plugin-chart-map-box reduces the diff towards MapLibre.
This PR updates Supercluster from v4 to v8, which improves performance and memory use for of this plugin.
TESTING INSTRUCTIONS
@rusackas , how does the review process generally work for these plugins? Are there some specific people who cover this part of the code?