Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: sql-templating #30337

Merged
merged 1 commit into from
Sep 19, 2024
Merged

docs: sql-templating #30337

merged 1 commit into from
Sep 19, 2024

Conversation

torgge
Copy link
Contributor

@torgge torgge commented Sep 19, 2024

"filter_values" function was more than one close parenthesis.

SUMMARY

Fixed documentation, to avoid using mistakes.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@torgge
Update sql-templating.mdx
a7b3a06 
"filter_values" function was more than one close parenthesis.
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Sep 19, 2024
villebro
villebro approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

github-actions[bot]
github-actions bot reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@michael-s-molina michael-s-molina changed the title fix: sql-templating docs: sql-templating Sep 19, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Sep 19, 2024
@michael-s-molina michael-s-molina merged commit 9b87ca9 into apache:master Sep 19, 2024
37 of 39 checks passed
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
doc Namespace | Anything related to documentation size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torgge @villebro @michael-s-molina