Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ECharts): Revert ECharts version bump #30388

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

geido
Copy link
Member

@geido geido commented Sep 25, 2024

SUMMARY

PR #29963 has bumped ECharts to version 5.5.1. However, we have seen several issues with running the frontend. This PR reverts ECharts to previous version 5.4.1.

BEFORE

image

TESTING INSTRUCTIONS

  1. Open a Dashboard with ECharts
  2. ECharts should load

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje
Copy link
Member

I guess that's our culprit... (from changelog)

image

@geido geido merged commit 046c096 into master Sep 25, 2024
35 of 36 checks passed
@michael-s-molina
Copy link
Member

michael-s-molina commented Sep 25, 2024

@rusackas @hainenber Maybe we should require PR authors to include the CHANGELOG in the PR description when bumping minor/major versions?

@michael-s-molina
Copy link
Member

michael-s-molina commented Sep 25, 2024

By the way, it seems ECharts does not respect semver as this was a minor bump with a breaking change given @kgabryje's screenshot. This will require additional attention when bumping ECharts.

@villebro for awareness.

@hainenber
Copy link
Contributor

Apologies all for the mess I made and thanks for fixing the horror @geido 👏

@michael-s-molina I will be more dilligent in bumping minor versions in the future. Semver is only a convention, after all 🤒

@michael-s-molina
Copy link
Member

Apologies all for the mess I made and thanks for fixing the horror @geido 👏

@michael-s-molina I will be more dilligent in bumping minor versions in the future. Semver is only a convention, after all 🤒

No problem at all @hainenber. We really appreciate all the amazing contributions you have made to Superset. My comment is just to keep improving the process 😉

@hainenber
Copy link
Contributor

Thanks. It's this amazing Superset community that aspire me to improve the platform further! 🙌

I think we might want to have some sort of Echarts integration test to keep ourselves less paranoid when it comes to bumping its version.

@villebro villebro deleted the geido/fix/echarts-version branch September 26, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants