fix: Incorrect hovered items in tooltips #30405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
the
v4.1
villebro
approved these changes
Sep 26, 2024
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
Outdated
Show resolved
Hide resolved
michael-s-molina
added
the
review:checkpoint
justinpark
approved these changes
Sep 26, 2024
michael-s-molina
removed
the
review:checkpoint
sadpandajoe
pushed a commit
that referenced
this pull request
Sep 28, 2024
(cherry picked from commit 36f7a3f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes an issue with incorrect hovered items in tooltips. The problem was that the algorithm was not considering that some dimension/metric combinations might result in series with missing data points.
Fixes #29565
Fixes #30045
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-09-26.at.13.12.03.mov
Screen.Recording.2024-09-26.at.13.12.43.mov
TESTING INSTRUCTIONS
Check the original issues for instructions.
ADDITIONAL INFORMATION