chore(number-formatter): upgrade pretty-ms to 9.1.0 #30599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
commented
Oct 14, 2024
| }); | ||
| test('format milliseconds in human readable format with default options', () => { | ||
| const formatter = createDurationFormatter(); | ||
| expect(formatter(-1000)).toBe('-1s'); |
There was a problem hiding this comment.
note the added negative duration tests that previously weren't supported.
9 tasks
villebro
changed the title
villebro
commented
Oct 14, 2024
| @@ -17,7 +17,7 @@ | |||
| * under the License. | |||
| */ | |||
|
|
|||
| import prettyMsFormatter from 'pretty-ms'; | |||
| import prettyMilliseconds, { Options } from 'pretty-ms'; | |||
There was a problem hiding this comment.
Renaming the default export to prettyMilliseconds, as that's what it's called in the source, and pull in Options via the newly exposed named export.
michael-s-molina
approved these changes
Oct 15, 2024
mistercrunch
pushed a commit
that referenced
this pull request
Oct 28, 2024
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bump
pretty-msfrom 7.0.0 to 9.1.0, as this package hasn't been bumped in a long time. Notable changes:colonNotationfor sub-second durations (the lock file was actually already pointing to 7.0.1)Other changes:
describe+ittotest.jestworking with the new version, aspretty-msandparse-msare now fully ESM.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION