Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Domain 'undefined' error in Storybook #30661

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

kgabryje
Copy link
Member

SUMMARY

Due to incorrect configuration of the default bootstrap data, part of the language pack was undefined, causing every component that uses t() (translation function) to crash.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

  1. npm run storybook
  2. Verify that storybook runs normally

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido merged commit e0ebeac into apache:master Oct 21, 2024
35 of 36 checks passed
@rusackas
Copy link
Member

THANK YOU!

nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants