Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dashboard): Native & Cross-Filters Scoping Performance #30881

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix(Dashboard): Native & Cross-Filters Scoping Performance #30881

merged 1 commit into from
Nov 8, 2024

Conversation

geido
Copy link
Member

@geido geido commented Nov 8, 2024 •
edited
Loading

SUMMARY

PR #30719 removed some logics from scoping of native and cross filters. However, unnecessary loops through filters and slices were still present and likely affecting performance for larger dashboards. This PR cleans that up.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Cross and native filter scoping should work as normal

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido marked this pull request as ready for review November 8, 2024 15:08
@dosubot dosubot bot added dashboard:cross-filters Related to the Dashboard cross filters dashboard:native-filters Related to the native filters of the Dashboard dashboard:performance Related to Dashboard performance labels Nov 8, 2024
@geido geido requested a review from kgabryje November 8, 2024 15:10
@geido geido force-pushed the geido/fix/native-cross-scoping-perf branch from 65f9b12 to 9f29b60 Compare November 8, 2024 16:08
@geido geido merged commit f4c36a6 into master Nov 8, 2024
34 checks passed
michael-s-molina pushed a commit that referenced this pull request Nov 19, 2024
@geido @michael-s-molina
fix(Dashboard): Native & Cross-Filters Scoping Performance (#30881)
264eebb 
(cherry picked from commit f4c36a6)
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 20, 2024
michael-s-molina pushed a commit that referenced this pull request Nov 20, 2024
@geido @michael-s-molina
fix(Dashboard): Native & Cross-Filters Scoping Performance (#30881)
7911ccc 
(cherry picked from commit f4c36a6)
sadpandajoe pushed a commit that referenced this pull request Nov 22, 2024
@geido @sadpandajoe
fix(Dashboard): Native & Cross-Filters Scoping Performance (#30881)
cebd457 
(cherry picked from commit f4c36a6)
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@geido @nyohasstium
fix(Dashboard): Native & Cross-Filters Scoping Performance (apache#30881
9a587e0 
)
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
@geido @sadpandajoe
fix(Dashboard): Native & Cross-Filters Scoping Performance (#30881)
654b1ff 
(cherry picked from commit f4c36a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
dashboard:cross-filters Related to the Dashboard cross filters dashboard:native-filters Related to the native filters of the Dashboard dashboard:performance Related to Dashboard performance size/L v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
Apache Superset 4.1.2
Status: Cherried
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geido @kgabryje @sadpandajoe