fix: added missing pod labels for init job #30956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glothriel
requested review from
craig-rueda,
dpgaspar,
villebro,
nytai and
michael-s-molina
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
villebro
reviewed
Nov 18, 2024
|
@villebro Some pre-check (helm docs modified?) failed for the previous commit, should I perform some additional action? |
|
@glothriel you need to run |
maxforasteiro
approved these changes
Nov 22, 2024
|
@glothriel this PR requires yet another rebase, as we're now already on version 0.13.3. Also, note that the version was not updated in the README in the latest commits, so you may want to consider installing |
glothriel
force-pushed
the
missing-pod-labels-for-init-job
branch
from
9758a50 to
65402a3
Compare
|
Ok guys i hope i got it this time |
maxforasteiro
approved these changes
Nov 27, 2024
|
@villebro Can I ask for review please? |
|
hey @villebro would it be possible to get this PR reviewed soon? |
villebro
approved these changes
Dec 6, 2024
villebro
requested changes
Dec 6, 2024
villebro
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added missing pod labels for init job. Without them it's impossible to dynamically set labels in environments with Network Policies engaged.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
skip
TESTING INSTRUCTIONS
Running helm template will suffice.
ADDITIONAL INFORMATION