-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add connector for Parseable #32052
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1f0d4ae
add support for parseable
AdheipSingh 4cd9ca2
update parseable
AdheipSingh a1156d9
run tests with pytest
AdheipSingh 0a05c70
address code review
AdheipSingh da7fda5
align docs
AdheipSingh 5d19e0d
update docs
AdheipSingh eb3ddcf
address pre-commit checks
AdheipSingh 726c9ed
fix lint issues
AdheipSingh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
from __future__ import annotations | ||
|
||
from datetime import datetime | ||
from typing import Any, TYPE_CHECKING | ||
|
||
from sqlalchemy import types | ||
|
||
from superset.constants import TimeGrain | ||
from superset.db_engine_specs.base import BaseEngineSpec | ||
|
||
if TYPE_CHECKING: | ||
from superset.connectors.sqla.models import TableColumn | ||
from superset.models.core import Database | ||
|
||
|
||
class ParseableEngineSpec(BaseEngineSpec): | ||
"""Engine spec for Parseable log analytics database.""" | ||
|
||
engine = "parseable" | ||
engine_name = "Parseable" | ||
|
||
_time_grain_expressions = { | ||
None: "{col}", | ||
TimeGrain.SECOND: "date_trunc('second', {col})", | ||
TimeGrain.MINUTE: "date_trunc('minute', {col})", | ||
TimeGrain.HOUR: "date_trunc('hour', {col})", | ||
TimeGrain.DAY: "date_trunc('day', {col})", | ||
TimeGrain.WEEK: "date_trunc('week', {col})", | ||
TimeGrain.MONTH: "date_trunc('month', {col})", | ||
TimeGrain.QUARTER: "date_trunc('quarter', {col})", | ||
TimeGrain.YEAR: "date_trunc('year', {col})", | ||
} | ||
|
||
@classmethod | ||
def epoch_to_dttm(cls) -> str: | ||
return "to_timestamp({col})" | ||
|
||
@classmethod | ||
def epoch_ms_to_dttm(cls) -> str: | ||
return "to_timestamp({col} / 1000)" | ||
|
||
@classmethod | ||
def convert_dttm( | ||
cls, target_type: str, dttm: datetime, db_extra: dict[str, Any] | None = None | ||
) -> str | None: | ||
sqla_type = cls.get_sqla_column_type(target_type) | ||
|
||
if isinstance(sqla_type, types.TIMESTAMP): | ||
return f"'{dttm.strftime('%Y-%m-%dT%H:%M:%S.000')}'" | ||
return None | ||
|
||
@classmethod | ||
def alter_new_orm_column(cls, orm_col: TableColumn) -> None: | ||
"""Handle p_timestamp column specifically for Parseable.""" | ||
if orm_col.column_name == "p_timestamp": | ||
orm_col.python_date_format = "epoch_ms" | ||
orm_col.is_dttm = True | ||
|
||
@classmethod | ||
def get_extra_params(cls, database: Database) -> dict[str, Any]: | ||
"""Additional parameters for Parseable connections.""" | ||
return { | ||
"engine_params": { | ||
"connect_args": { | ||
"timeout": 300, # 5 minutes timeout | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
from datetime import datetime | ||
from typing import Optional | ||
|
||
import pytest | ||
|
||
from tests.unit_tests.db_engine_specs.utils import assert_convert_dttm | ||
from tests.unit_tests.fixtures.common import dttm # noqa: F401 | ||
|
||
|
||
def test_epoch_to_dttm() -> None: | ||
""" | ||
DB Eng Specs (parseable): Test epoch to dttm | ||
""" | ||
from superset.db_engine_specs.parseable import ParseableEngineSpec | ||
|
||
assert ParseableEngineSpec.epoch_to_dttm() == "to_timestamp({col})" | ||
|
||
|
||
def test_epoch_ms_to_dttm() -> None: | ||
""" | ||
DB Eng Specs (parseable): Test epoch ms to dttm | ||
""" | ||
from superset.db_engine_specs.parseable import ParseableEngineSpec | ||
|
||
assert ParseableEngineSpec.epoch_ms_to_dttm() == "to_timestamp({col} / 1000)" | ||
|
||
|
||
def test_alter_new_orm_column() -> None: | ||
""" | ||
DB Eng Specs (parseable): Test alter orm column | ||
""" | ||
from superset.connectors.sqla.models import SqlaTable, TableColumn | ||
from superset.db_engine_specs.parseable import ParseableEngineSpec | ||
from superset.models.core import Database | ||
|
||
database = Database(database_name="parseable", sqlalchemy_uri="parseable://db") | ||
tbl = SqlaTable(table_name="tbl", database=database) | ||
col = TableColumn(column_name="p_timestamp", type="TIMESTAMP", table=tbl) | ||
ParseableEngineSpec.alter_new_orm_column(col) | ||
assert col.python_date_format == "epoch_ms" | ||
assert col.is_dttm is True | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"target_type,expected_result", | ||
[ | ||
("TIMESTAMP", "'2019-01-02T03:04:05.000'"), | ||
("UnknownType", None), | ||
], | ||
) | ||
def test_convert_dttm( | ||
target_type: str, | ||
expected_result: Optional[str], | ||
dttm: datetime, # noqa: F811 | ||
) -> None: | ||
""" | ||
DB Eng Specs (parseable): Test conversion to date time | ||
""" | ||
from superset.db_engine_specs.parseable import ParseableEngineSpec | ||
|
||
assert_convert_dttm(ParseableEngineSpec, target_type, expected_result, dttm) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing NULL Handling in Time Expressions![category Functionality](https://camo.githubusercontent.com/be66cdb454480bb0cbb9d568c5947d38543421fabac2bcbd8b17a41babf9d7f2/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f46756e6374696f6e616c6974792d303238346337)
Tell me more
What is the issue?
The time grain expressions don't account for possible NULL values in timestamp columns, which could cause queries to fail.
Why this matters
Queries may fail when processing NULL timestamp values, affecting data analysis and visualization reliability.
Suggested change ∙ Feature Preview
Add NULL handling to the time grain expressions:
💬 Chat with Korbit by mentioning @korbit-ai.