Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(DrillDetailTableControls): Upgrade DrillDetailTableControls component to Ant Design 5 #32313

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Feb 19, 2025

SUMMARY

  • Migrates DrillDetailTableControls component to Ant Design 5
  • Adds DrillDetailTableControls.stories

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before
    before
  • After
    after

TESTING INSTRUCTIONS

  1. CI should pass
  2. The testing suite should pass
  3. Check for visual changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Adds DrillDetailTableControls.stories
- Migrates DrillDetailTableControls component to Ant Design 5
@EnxDev EnxDev added frontend:refactor Related to refactoring the frontend frontend:refactor:antd5 labels Feb 19, 2025
@EnxDev EnxDev requested review from kgabryje and geido February 19, 2025 17:04
@dosubot dosubot bot added the change:frontend Requires changing the frontend label Feb 19, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Fix Detected
Functionality Missing React Type Import ▹ view
Files scanned
File Path Reviewed
superset-frontend/src/types/TagType.ts
superset-frontend/src/components/Chart/DrillDetail/DrillDetailTableControls.stories.tsx
superset-frontend/src/components/Tags/Tag.tsx
superset-frontend/src/components/Chart/DrillDetail/DrillDetailTableControls.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@@ -28,6 +28,7 @@ export interface TagType {
name: string;
index?: number | undefined;
toolTipTitle?: string;
children?: React.ReactNode;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing React Type Import category Functionality

Tell me more
What is the issue?

The children prop is added without importing React type, which will cause a TypeScript compilation error.

Why this matters

Without proper React type import, the application will fail to compile, preventing the Ant Design 5 upgrade from working correctly.

Suggested change ∙ Feature Preview

Add React import at the top of the file:

import { MouseEventHandler, ReactNode } from 'react';

export interface TagType {
  // ... other props
  children?: ReactNode;
}

Report a problem with this comment

💬 Chat with Korbit by mentioning @korbit-ai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend frontend:refactor:antd5 frontend:refactor Related to refactoring the frontend size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant