Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New "Time Series - Table" visualization #3543

Merged
merged 4 commits into from
Oct 4, 2017
Merged

New "Time Series - Table" visualization #3543

merged 4 commits into from
Oct 4, 2017

Conversation

mistercrunch
Copy link
Member

screen shot 2017-09-27 at 5 00 30 pm

screen shot 2017-09-27 at 5 00 12 pm

todo:

  • compare to other columns
  • allow user-defined info-bubble-tooltip per column
  • contribution to total
  • Period compare sparkline
  • ...

@coveralls
Copy link

coveralls commented Sep 28, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 69.885% when pulling 155f504147cfad8a5290ac5c7ca26c88fd2e0d6f on mistercrunch:time_table into f829b48 on apache:master.

@mistercrunch mistercrunch force-pushed the time_table branch 2 times, most recently from fd2b81c to 4e6f524 Compare September 30, 2017 15:38
@coveralls
Copy link

coveralls commented Sep 30, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.019% when pulling 4e6f5241b7cd8647f36d7b90f3ed63c1c2adc258 on mistercrunch:time_table into 0bd2ac5 on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 70.019% when pulling 4e6f5241b7cd8647f36d7b90f3ed63c1c2adc258 on mistercrunch:time_table into 0bd2ac5 on apache:master.

@coveralls
Copy link

coveralls commented Sep 30, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.019% when pulling cb7d9a4b266656d8dd81c79faa2a1af81d2de742 on mistercrunch:time_table into 0bd2ac5 on apache:master.

@fabianmenges
Copy link
Contributor

Very nice, I had gotten requests for something like this as well...

@mistercrunch
Copy link
Member Author

@fabianmenges this also ships with a reusable "CollectionControl" that can be used to get an arbitrary array of controls and is smoothly sortable with dragndrop. We're having more and more use cases for collections in controls...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 70.019% when pulling e98daaf6dcb9548f804add17c0b28cb389780600 on mistercrunch:time_table into bc3ad64 on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 2, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.019% when pulling e98daaf6dcb9548f804add17c0b28cb389780600 on mistercrunch:time_table into bc3ad64 on apache:master.

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 69.858% when pulling 1a53052f898271fcdc023b75585967100c16adc3 on mistercrunch:time_table into 18e459e on apache:master.

@fabianmenges
Copy link
Contributor

I'll take a look at the CollectionControl sounds interesting.

@mistercrunch mistercrunch force-pushed the time_table branch 2 times, most recently from cda3283 to 42f3609 Compare October 3, 2017 19:37
@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.003% when pulling cda3283c29806b82ebbb921ca411e4ea3b1a9f9e on mistercrunch:time_table into 18e459e on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 70.003% when pulling cda3283c29806b82ebbb921ca411e4ea3b1a9f9e on mistercrunch:time_table into 18e459e on apache:master.

@mistercrunch mistercrunch force-pushed the time_table branch 2 times, most recently from 7ff6ad8 to 255d1f8 Compare October 3, 2017 19:50
@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.003% when pulling 255d1f853fefd88e7e04c3b0d5dba6794888e201 on mistercrunch:time_table into 18e459e on apache:master.

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.003% when pulling 255d1f853fefd88e7e04c3b0d5dba6794888e201 on mistercrunch:time_table into 18e459e on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 69.728% when pulling e92ab74 on mistercrunch:time_table into 076f9cd on apache:master.

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.003% when pulling e92ab74 on mistercrunch:time_table into 076f9cd on apache:master.

@coveralls
Copy link

coveralls commented Oct 4, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.003% when pulling 0ba06f0e5603cffb2d99deab9aa38428bb02fc9c on mistercrunch:time_table into 076f9cd on apache:master.

@mistercrunch mistercrunch changed the title [WiP] adding a new "Time Series - Table" viz New "Time Series - Table" visualization Oct 4, 2017
@coveralls
Copy link

coveralls commented Oct 4, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.003% when pulling d1733b96c25fb4b8d09483ffd3f808d7e5b6435d on mistercrunch:time_table into 076f9cd on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 70.003% when pulling 45fca52 on mistercrunch:time_table into 076f9cd on apache:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 4, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 70.003% when pulling 45fca52 on mistercrunch:time_table into 076f9cd on apache:master.

graceguo-supercat
graceguo-supercat approved these changes Oct 4, 2017
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch merged commit bb0f69d into apache:master Oct 4, 2017
@mistercrunch mistercrunch deleted the time_table branch October 4, 2017 17:17
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
New "Time Series - Table" visualization (apache#3543)
23a8adb 
* [WiP] adding a new "Time Series - Table" viz

* Adding drag-n-drop to collection

* Using keys in arrays

* tests
This was referenced Jul 15, 2021
Closed
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.2 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistercrunch @coveralls @fabianmenges @graceguo-supercat