Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make colorpickercontrol refer to default color scheme #6031

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Oct 4, 2018

This will reduce the code that point to specific color scheme and let ColorSchemeManager be the single point of contact for obtaining color scheme.
Developers can set company-specific default color scheme in common.js.

@williaster @conglei @graceguo-supercat

@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #6031 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6031      +/-   ##
==========================================
+ Coverage   64.63%   64.65%   +0.02%     
==========================================
  Files         449      449              
  Lines       23821    23817       -4     
  Branches     2639     2639              
==========================================
+ Hits        15396    15400       +4     
+ Misses       8412     8404       -8     
  Partials       13       13
Impacted Files Coverage Δ
superset/assets/src/modules/colors.js 44% <ø> (-7.73%) ⬇️
...explore/components/controls/ColorPickerControl.jsx 96.15% <100%> (ø) ⬆️
superset/assets/src/modules/colorSchemes/airbnb.js 0% <0%> (-100%) ⬇️
superset/assets/src/modules/colorSchemes/lyft.js 0% <0%> (-100%) ⬇️
superset/connectors/sqla/models.py 81.13% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.7% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df64eca...fc3e2e4. Read the comment docs.

@williaster williaster merged commit 8fe6f12 into apache:master Oct 5, 2018
@kristw kristw deleted the kristw-color branch October 5, 2018 21:22
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants