Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard editor] use the theme's btn-primary #6859

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Feb 12, 2019

I'm not sure why btn-primary was made black for dashboard specifically, but want to bring back consistency.

before

screen shot 2019-02-12 at 9 13 52 am

after

screen shot 2019-02-12 at 9 12 09 am

@codecov-io
Copy link

Codecov Report

Merging #6859 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6859   +/-   ##
=======================================
  Coverage   56.31%   56.31%           
=======================================
  Files         527      527           
  Lines       23529    23529           
  Branches     2782     2782           
=======================================
  Hits        13251    13251           
  Misses       9866     9866           
  Partials      412      412

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044f660...ec328ac. Read the comment docs.

2 similar comments
@codecov-io
Copy link

Codecov Report

Merging #6859 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6859   +/-   ##
=======================================
  Coverage   56.31%   56.31%           
=======================================
  Files         527      527           
  Lines       23529    23529           
  Branches     2782     2782           
=======================================
  Hits        13251    13251           
  Misses       9866     9866           
  Partials      412      412

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044f660...ec328ac. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #6859 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6859   +/-   ##
=======================================
  Coverage   56.31%   56.31%           
=======================================
  Files         527      527           
  Lines       23529    23529           
  Branches     2782     2782           
=======================================
  Hits        13251    13251           
  Misses       9866     9866           
  Partials      412      412

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044f660...ec328ac. Read the comment docs.

@williaster
Copy link
Contributor

@elibrumbaugh do you have thoughts on this?

@williaster
Copy link
Contributor

williaster commented Feb 12, 2019

originally this was meant to enable going to a more minimal design system, but priorities may have shifted since then. I don't have a strong opinion on it.

@mistercrunch
Copy link
Member Author

I also don't have a strong opinion, I just want a single consistent btn-primary look throughout

@mistercrunch
Copy link
Member Author

closes #6891

@mistercrunch
Copy link
Member Author

@elibrumbaugh ping

@mistercrunch
Copy link
Member Author

mistercrunch commented Mar 5, 2019

I'm going to merge this since it's been open for 21 days. I'm ok to revert if needed.

@mistercrunch mistercrunch merged commit 0421786 into apache:master Mar 5, 2019
@kristw kristw added enhancement:request Enhancement request submitted by anyone from the community and removed #refine labels Mar 20, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels enhancement:request Enhancement request submitted by anyone from the community 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants