Smarter redirect on slice creation #691
Conversation
|
Coverage decreased (-0.3%) to 80.816% when pulling 4a9fbff852ba6cbf77877f539229e62aee804f78 on xrmx:smartercreateslice into dbb9356 on airbnb:master. |
|
Coverage decreased (-0.3%) to 80.816% when pulling 430db630661097b7f139616c295e7006eb1e2699 on xrmx:smartercreateslice into dbb9356 on airbnb:master. |
|
Coverage decreased (-0.3%) to 80.768% when pulling 2aafb7413d5197b2a8bf32413efff1b16e687f05 on xrmx:smartercreateslice into 8135c24 on airbnb:master. |
|
Hello, anything i can do to move this forward? thanks |
xrmx
force-pushed
the
smartercreateslice
branch
2 times, most recently
from
5c7d345 to
0c68bc7
Compare
|
Coverage increased (+0.4%) to 81.513% when pulling 0c68bc73f9f96d7fd1af87b2b92aec9e894aa409 on xrmx:smartercreateslice into ee9141a on airbnb:master. |
|
Coverage increased (+0.3%) to 81.483% when pulling b253b258751df6a78c30af3363468c5db0789532 on xrmx:smartercreateslice into ee9141a on airbnb:master. |
After ea8a7ec creating a slice started redirecting to druid datasource from sqlalchemy tables. That's quite painful for sqlalchemy tables users. Instead of hardcoding a choice just query the db, if we don't have any druid datasource fallback to sqlalchemy tables. Bonus points we remove hacky javascript and make the message translatable. While at it fix druid client test to not hardcode datasource id.
|
Sorry about the delay, I have merged a while back... |
mistercrunch
added
🏷️ bot
After ea8a7ec creating a slice
started redirecting to druid datasource from sqlalchemy tables.
That's quite painful for sqlalchemy tables users.
Instead of hardcoding a choice just query the db, if we don't
have any druid datasource fallback to sqlalchemy tables.
Bonus points we remove hacky javascript and make the message
translatable.
While at it fix druid client test to not hardcode datasource id.