Fix rendering regression from the introduction of bignumber #6937
+130
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In superset-ui 0.8.0, we used bignumber.js to transform numbers in chartProps' payload from plain 64-bit floats to BigNumber instances. This causes a number of charts to render incorrectly when comparison functions in the rendering algorithms operate on BigNumber objects instead of floats. This PR uses the preTransformProps step in SuperChart to transform BigNumber instances back to floats so charts can render properly.
xtinec
added
!deprecated-label:bug
Codecov Report
@@ Coverage Diff @@
## master #6937 +/- ##
==========================================
+ Coverage 63.98% 63.99% +<.01%
==========================================
Files 422 423 +1
Lines 20537 20555 +18
Branches 2230 2235 +5
==========================================
+ Hits 13141 13154 +13
- Misses 7264 7269 +5
Partials 132 132
Continue to review full report at Codecov.
|
williaster
reviewed
Feb 25, 2019
| // floats instead of BigNumber instances in their props to properly render. | ||
| import BigNumber from 'bignumber.js'; | ||
|
|
||
| export default function transform(payload) { |
There was a problem hiding this comment.
transformBigNumber? there's a lint rule for this we should enable.
| payload[key] = transform(payload[key]); | ||
| } | ||
| } | ||
| } else if (payload.constructor === Array) { |
There was a problem hiding this comment.
I think Array.isArray is preferred
xtinec
added a commit
that referenced
this pull request
Feb 26, 2019
In superset-ui 0.8.0, we used bignumber.js to transform numbers in chartProps' payload from plain 64-bit floats to BigNumber instances. This causes a number of charts to render incorrectly when comparison functions in the rendering algorithms operate on BigNumber objects instead of floats. This PR uses the preTransformProps step in SuperChart to transform BigNumber instances back to floats so charts can render properly. (cherry picked from commit 73cdb37)
|
I'm a bit concerned about recursing through all payloads looking for How do BigNumber come to life first, any way handle it there? |
xtinec
added a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 3, 2019
Revert "Fix rendering regression from the introduction of bignumber (apache#6937)"
xtinec
added a commit
that referenced
this pull request
Apr 3, 2019
…bignumber.js change to SQL editor in an opt-in fashion (#7210) * revert: bignumber patch to prevent rendering regression in charts * Revert "Fix rendering regression from the introduction of bignumber (#6937)" * fix: consume the bignumber.js reversion -- apply the bignumber conversion in `actions/sqlLab.js` where it is needed (aka opt into bignumber.js). * Revert "Fix deck.gl form data (#6953)" b/c formData now returns snake_cased properties for deck vizzes.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In superset-ui 0.8.0, we used bignumber.js to transform numbers in chartProps' payload from plain 64-bit floats to BigNumber instances. This causes a number of charts to render incorrectly when comparison functions in the rendering algorithms operate on BigNumber objects instead of floats. This PR uses the preTransformProps step in SuperChart to transform BigNumber instances back to floats so charts can render properly.
cc @soboko