Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datasource] Ensuring consistent behavior of datasource editing/saving. #7037

Merged
merged 2 commits into from
Mar 18, 2019
Merged

[datasource] Ensuring consistent behavior of datasource editing/saving. #7037

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e98cc0e
Update datasource.py
john-bodley Mar 14, 2019
57fac18
Update datasource.py
john-bodley Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions superset/views/datasource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,11 @@
from flask import request
from flask_appbuilder import expose
from flask_appbuilder.security.decorators import has_access_api
from flask_babel import gettext as __

from superset import appbuilder, db
from superset.connectors.connector_registry import ConnectorRegistry
from superset.models.core import Database
from .base import BaseSupersetView, check_ownership, json_error_response
from .base import BaseSupersetView, json_error_response


class Datasource(BaseSupersetView):
Expand All @@ -39,14 +38,6 @@ def save(self):
orm_datasource = ConnectorRegistry.get_datasource(
datasource_type, datasource_id, db.session)

if not check_ownership(orm_datasource, raise_if_false=False):
return json_error_response(
__(
'You are not authorized to modify '
'this data source configuration'),
status='401',
)

if 'owners' in datasource:
datasource['owners'] = db.session.query(orm_datasource.owner_class).filter(
orm_datasource.owner_class.id.in_(datasource['owners'])).all()
Expand Down