Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Lab] Fixed TableElement sorting functionality and tests (#7069) #7070

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

enricoberti
Copy link
Contributor

Also updated the test to get the first col from the mock table

@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #7070 into master will increase coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7070      +/-   ##
==========================================
+ Coverage   64.46%   64.47%   +<.01%     
==========================================
  Files         421      421              
  Lines       20537    20544       +7     
  Branches     2247     2249       +2     
==========================================
+ Hits        13240    13246       +6     
- Misses       7170     7171       +1     
  Partials      127      127
Impacted Files Coverage Δ
...rset/assets/src/SqlLab/components/TableElement.jsx 89.18% <87.5%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2524219...c863b88. Read the comment docs.

@mistercrunch
Copy link
Member

This indeterministic test has been bugging me every now and then. LGTM

@mistercrunch mistercrunch merged commit 30f88ca into apache:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants