Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change number format default #7137

Merged
merged 38 commits into from
Apr 2, 2019
Merged

Change number format default #7137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
1ef7fb6
Sparkline dates aren't formatting in Time Series Table (#6976)
khtruong Mar 5, 2019
e7d97db
Fix the white background shown in SQL editor on drag (#7021)
xtinec Mar 13, 2019
e6886fb
Show tooltip with time frame (#6979)
betodealmeida Mar 13, 2019
b3966e4
Fix time filter control (#6978)
betodealmeida Mar 13, 2019
f4e3923
Enhancement of query context and object. (#6962)
conglei Mar 5, 2019
d7b2c3e
[fix] /superset/slice/id url is too long (#6989)
Mar 10, 2019
9855837
[WIP] fix user specified JSON metadata not updating dashboard on refr…
thunter009 Mar 14, 2019
6d0c390
feat: add ability to change font size in big number (#7003)
khtruong Mar 19, 2019
0e1a3d3
Allow LIMIT to be specified in parameters (#7052)
betodealmeida Mar 20, 2019
0c65b3f
[fix] Cursor jumping when editing chart and dashboard titles (#7038)
Mar 15, 2019
c65a166
Changing time table viz to pass formatTime a date (#7020)
michellethomas Mar 13, 2019
771d212
[db-engine-spec] Aligning Hive/Presto partition logic (#7007)
john-bodley Mar 13, 2019
fa73a8d
[fix] explore chart from dashboard missed slice title (#7046)
Mar 16, 2019
8d6e3f1
fix inaccurate data calculation with adata rolling and contribution (…
conglei Mar 14, 2019
6d0752c
Adding warning message for sqllab save query (#7028)
michellethomas Mar 18, 2019
bd2a8b5
[datasource] Ensuring consistent behavior of datasource editing/savin…
john-bodley Mar 18, 2019
81a1287
[csv-upload] Fixing message encoding (#6971)
john-bodley Mar 3, 2019
6a7d5fc
[sql-parse] Fixing LIMIT exceptions (#6963)
john-bodley Mar 5, 2019
ee85089
Adding custom control overrides (#6956)
michellethomas Mar 6, 2019
7bc3006
[sqlparse] Fixing table name extraction for ill-defined query (#7029)
john-bodley Mar 15, 2019
4ffc1b3
[missing values] Removing replacing missing values (#4905)
john-bodley Mar 21, 2019
dfc0010
[SQL Lab] Improved query and results tabs rendering reliability (#7082)
enricoberti Mar 21, 2019
98cf417
Fix filter_box migration PR #6523 (#7066)
mistercrunch Mar 21, 2019
959199d
SQL editor layout makeover (#7102)
xtinec Mar 25, 2019
b599855
[forms] Fix handling of NULLs
Mar 21, 2019
9d21f70
handle null column_name in sqla and druid models
Mar 19, 2019
bdbb354
Use metric name instead of metric in filter box (#7106)
michellethomas Mar 25, 2019
87fb2df
Bump python lib croniter to an existing version (#7132)
mistercrunch Mar 26, 2019
b7fb15f
Revert PR #6933 (#7162)
betodealmeida Mar 28, 2019
0ea1b42
[bugfix] SQL Lab 'Filter Results' doesn't stick (#7104)
mistercrunch Mar 28, 2019
4407442
Injectable statsd client (#7138)
DiggidyDave Mar 27, 2019
71eea53
[Lyft-GA] Enable color consistency in a dashboard (#7135)
khtruong Mar 29, 2019
21834d3
Fix double scroll bars when content of sql result table overflows hor…
xtinec Mar 29, 2019
49cf9bf
Change number format default
khtruong Mar 26, 2019
20c7cb3
Use smart formatter instead
khtruong Mar 27, 2019
e74149f
Merge branch 'lyftga' into VIZ-213
khtruong Apr 1, 2019
e361cb7
fix merge issues
khtruong Apr 1, 2019
aff3878
Use SMART_NUMBER
khtruong Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions superset/assets/backendSync.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,7 +1635,7 @@
"freeForm": true,
"label": "Number format",
"renderTrigger": true,
"default": ".3s",
"default": "SMART_NUMBER",
"choices": [
[
".1s",
Expand Down Expand Up @@ -2085,7 +2085,7 @@
"freeForm": true,
"label": "X Axis Format",
"renderTrigger": true,
"default": ".3s",
"default": "SMART_NUMBER",
"choices": [
[
".1s",
Expand Down Expand Up @@ -2165,7 +2165,7 @@
"freeForm": true,
"label": "Y Axis Format",
"renderTrigger": true,
"default": ".3s",
"default": "SMART_NUMBER",
"choices": [
[
".1s",
Expand Down Expand Up @@ -2206,7 +2206,7 @@
"type": "SelectControl",
"freeForm": true,
"label": "Right Axis Format",
"default": ".3s",
"default": "SMART_NUMBER",
"choices": [
[
".1s",
Expand Down
3 changes: 0 additions & 3 deletions superset/assets/src/explore/controlPanels/Bubble.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ export default {
},
],
controlOverrides: {
x_axis_format: {
default: '.3s',
},
color_scheme: {
renderTrigger: false,
},
Expand Down
9 changes: 5 additions & 4 deletions superset/assets/src/explore/controls.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ const D3_FORMAT_DOCS = 'D3 format syntax: https://github.com/d3/d3-format';

// input choices & options
const D3_FORMAT_OPTIONS = [
['SMART_NUMBER', 'Adaptative formating'],
['.1s', '.1s (12345.432 => 10k)'],
['.3s', '.3s (12345.432 => 12.3k)'],
[',.1%', ',.1% (12345.432 => 1,234,543.2%)'],
Expand Down Expand Up @@ -989,7 +990,7 @@ export const controls = {
freeForm: true,
label: t('Number format'),
renderTrigger: true,
default: '.3s',
default: 'SMART_NUMBER',
choices: D3_FORMAT_OPTIONS,
description: D3_FORMAT_DOCS,
},
Expand Down Expand Up @@ -1232,7 +1233,7 @@ export const controls = {
freeForm: true,
label: t('X Axis Format'),
renderTrigger: true,
default: '.3s',
default: 'SMART_NUMBER',
choices: D3_FORMAT_OPTIONS,
description: D3_FORMAT_DOCS,
},
Expand All @@ -1252,7 +1253,7 @@ export const controls = {
freeForm: true,
label: t('Y Axis Format'),
renderTrigger: true,
default: '.3s',
default: 'SMART_NUMBER',
choices: D3_FORMAT_OPTIONS,
description: D3_FORMAT_DOCS,
mapStateToProps: (state) => {
Expand All @@ -1273,7 +1274,7 @@ export const controls = {
type: 'SelectControl',
freeForm: true,
label: t('Right Axis Format'),
default: '.3s',
default: 'SMART_NUMBER',
choices: D3_FORMAT_OPTIONS,
description: D3_FORMAT_DOCS,
},
Expand Down