Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [lyftga] pass the latest deckgl props #7208

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Conversation

khtruong
Copy link
Contributor

@khtruong khtruong commented Apr 2, 2019

SUMMARY

Map styles would not update for a few deck.gl viz types. This is because we saved map style and other props as class variables once in the AnimatableDeckGLContainer constructor and never updated these properties even if the user changed things like the map style. Instead of referring to class variables, I explicitly list out the props and pass the props thru.

TEST PLAN

Manually tested

ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[x] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@xtinec @betodealmeida @williaster @kristw

@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #7208 into lyftga will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           lyftga   #7208      +/-   ##
=========================================
+ Coverage    64.5%   64.5%   +<.01%     
=========================================
  Files         424     424              
  Lines       20668   20667       -1     
  Branches     2268    2268              
=========================================
  Hits        13332   13332              
+ Misses       7213    7212       -1     
  Partials      123     123
Impacted Files Coverage Δ
...isualizations/deckgl/AnimatableDeckGLContainer.jsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a0b57...6e5856b. Read the comment docs.

Copy link
Contributor

@xtinec xtinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtinec xtinec merged commit 200efac into apache:lyftga Apr 3, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants