Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition when fetching results in SQL Lab (#7198) #7242

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix race condition when fetching results in SQL Lab (#7198) #7242

merged 1 commit into from
Apr 8, 2019

Conversation

michellethomas
Copy link
Contributor

  • Fix race condition when fetching results in SQL Lab

  • Fix lint

(cherry picked from commit ca6a73b)

SUMMARY

Cherry picking change that got into lyftga and is impacting superset users running sql queries. Queries get to 100% and don't return results because the query is marked as successful but has no resultsKey.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Run multiple queries in a row with large payloads
Confirm that they hit 100% and return results

ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[x] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@john-bodley @graceguo-supercat @betodealmeida @xtinec

@betodealmeida @michellethomas
Fix race condition when fetching results in SQL Lab (apache#7198)
93bdc74 
* Fix race condition when fetching results in SQL Lab

* Fix lint

(cherry picked from commit ca6a73b)
@michellethomas michellethomas added !deprecated-label:bug Deprecated label - Use #bug instead v0.31 sqllab Namespace | Anything related to the SQL Lab labels Apr 8, 2019
@codecov-io
Copy link

Codecov Report

Merging #7242 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7242      +/-   ##
==========================================
- Coverage   64.63%   64.62%   -0.01%     
==========================================
  Files         422      422              
  Lines       20595    20593       -2     
  Branches     2253     2253              
==========================================
- Hits        13311    13309       -2     
  Misses       7161     7161              
  Partials      123      123
Impacted Files Coverage Δ
superset/views/core.py 74.92% <ø> (ø) ⬆️
superset/sql_lab.py 76.37% <100%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e767e4d...93bdc74. Read the comment docs.

@michellethomas michellethomas merged commit 52473c5 into apache:master Apr 8, 2019
@michellethomas michellethomas deleted the sqllab_query_bug_cherry branch April 8, 2019 22:09
michellethomas added a commit that referenced this pull request Apr 8, 2019
@michellethomas
Fix race condition when fetching results in SQL Lab (#7198) (#7242)
2ab07a0 
* Fix race condition when fetching results in SQL Lab

* Fix lint

(cherry picked from commit ca6a73b)
(cherry picked from commit 52473c5)
@swtnk swtnk mentioned this pull request Nov 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
!deprecated-label:bug Deprecated label - Use #bug instead sqllab Namespace | Anything related to the SQL Lab v0.31
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michellethomas @codecov-io @john-bodley @betodealmeida