Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increment version numbers #7245

Merged
merged 3 commits into from
Apr 8, 2019

Conversation

datability-io
Copy link
Contributor

@datability-io datability-io commented Apr 8, 2019

SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[x] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@kristw
Copy link
Contributor

kristw commented Apr 8, 2019

@datability-io If you are to bump the version from 0.10.x to 0.11.x, better bump all the @superset-ui altogether, not just chart, to avoid bugs due to npm install multiple copies of the dependencies and mess with the singletons.

To verify, check if the build has any warning and cat package.json | grep "@superset-ui" to make sure it does not install multiple copies of any package.

@codecov-io
Copy link

codecov-io commented Apr 8, 2019

Codecov Report

Merging #7245 into lyftga will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           lyftga    #7245   +/-   ##
=======================================
  Coverage   64.53%   64.53%           
=======================================
  Files         425      425           
  Lines       20861    20861           
  Branches     2280     2280           
=======================================
  Hits        13463    13463           
  Misses       7272     7272           
  Partials      126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6876f7...c32f0c2. Read the comment docs.

@xtinec xtinec merged commit ad7cc01 into apache:lyftga Apr 8, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants