Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to documentation #7251

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Add link to documentation #7251

merged 1 commit into from
Apr 9, 2019

Conversation

betodealmeida
Copy link
Member

SUMMARY

Allow users to add a link pointing to documentation.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

I added a question mark to the left of the bug nub:

Screen Shot 2019-04-08 at 11 35 48 PM

ADDITIONAL INFORMATION
[ ] Has associated issue:
[X] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[X] Introduces new feature or API
[ ] Removes existing feature or API
[ ] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@mistercrunch @xtinec @khtruong @datability-io

@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #7251 into lyftga will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           lyftga    #7251      +/-   ##
==========================================
+ Coverage   64.53%   64.53%   +<.01%     
==========================================
  Files         425      425              
  Lines       20861    20862       +1     
  Branches     2280     2280              
==========================================
+ Hits        13463    13464       +1     
  Misses       7272     7272              
  Partials      126      126
Impacted Files Coverage Δ
superset/config.py 93.78% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ef41f...7fa13be. Read the comment docs.

@khtruong
Copy link
Contributor

khtruong commented Apr 9, 2019

Can you make sure @dorq is good with these changes?

@dorq
Copy link

dorq commented Apr 9, 2019

@betodealmeida Can you show me what the window looks like at 1680px wide?

@betodealmeida
Copy link
Member Author

@dorq:

Screen Shot 2019-04-09 at 9 30 17 AM

@dorq
Copy link

dorq commented Apr 9, 2019

LGTM

@betodealmeida betodealmeida merged commit 5154421 into apache:lyftga Apr 9, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants