Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass viz type to GET requests #7255

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Pass viz type to GET requests #7255

merged 2 commits into from
Apr 9, 2019

Conversation

betodealmeida
Copy link
Member

SUMMARY

We need to pass the visualization type to the initial GET request in the Explore view, since the payload is dependent on it.

TEST PLAN

We had a problem where:

  1. User would create a new chart in Explore, using table view.
  2. User would switch to a different visualization type.
  3. Client would run a GET based only on the slice id, returning the wrong payload type. In our case, the Mapbox API key was not sent.

I changed the GET request to pass the visualization type. Another alternative might be to not use GET requests in the Explore view, at the cost of the initial load being slow. I'll monitor this during the first days of GA.

ADDITIONAL INFORMATION
[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[X] Fixes bug
[ ] Refactors code
[ ] Adds test(s)
REVIEWERS

@xtinec

@codecov-io
Copy link

Codecov Report

Merging #7255 into lyftga will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           lyftga   #7255      +/-   ##
=========================================
+ Coverage   64.55%   64.6%   +0.04%     
=========================================
  Files         425     425              
  Lines       20870   20891      +21     
  Branches     2282    2296      +14     
=========================================
+ Hits        13472   13496      +24     
+ Misses       7272    7269       -3     
  Partials      126     126
Impacted Files Coverage Δ
superset/views/utils.py 88.09% <100%> (ø) ⬆️
superset/assets/src/explore/exploreUtils.js 75.72% <50%> (-0.75%) ⬇️
...assets/src/visualizations/deckgl/layers/common.jsx 62.29% <0%> (+28.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c80cf5...d43ceaf. Read the comment docs.

@betodealmeida betodealmeida merged commit 078a977 into apache:lyftga Apr 9, 2019
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Apr 10, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants