Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We need to pass the visualization type to the initial
GET
request in the Explore view, since the payload is dependent on it.TEST PLAN
We had a problem where:
GET
based only on the slice id, returning the wrong payload type. In our case, the Mapbox API key was not sent.I changed the
GET
request to pass the visualization type. Another alternative might be to not useGET
requests in the Explore view, at the cost of the initial load being slow. I'll monitor this during the first days of GA.ADDITIONAL INFORMATION
REVIEWERS
@xtinec