Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to scheduled pipeline #7584

Merged
merged 4 commits into from
May 23, 2019
Merged

Add link to scheduled pipeline #7584

merged 4 commits into from
May 23, 2019

Conversation

betodealmeida
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

When showing the config for a scheduled query, allow user to link to the pipeline via the config.

This is #7536, but merging into master.

@codecov-io
Copy link

Codecov Report

Merging #7584 into master will decrease coverage by <.01%.
The diff coverage is 45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7584      +/-   ##
==========================================
- Coverage   65.17%   65.17%   -0.01%     
==========================================
  Files         433      434       +1     
  Lines       21429    21444      +15     
  Branches     2360     2366       +6     
==========================================
+ Hits        13967    13976       +9     
- Misses       7342     7348       +6     
  Partials      120      120
Impacted Files Coverage Δ
superset/views/sql_lab.py 85.71% <0%> (-1.25%) ⬇️
superset/assets/src/showSavedQuery/index.jsx 0% <0%> (ø) ⬆️
superset/assets/src/showSavedQuery/utils.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5739fb...6760dca. Read the comment docs.

@betodealmeida
Copy link
Member Author

This was reviewed in #7536

@betodealmeida betodealmeida merged commit 265e117 into apache:master May 23, 2019
@betodealmeida betodealmeida mentioned this pull request May 23, 2019
12 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants