Improve performance for add slice container #7791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellethomas
approved these changes
Jul 1, 2019
mistercrunch
approved these changes
Jul 1, 2019
12 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The dropdown for the add slice page was super slow and laggy, and too small to fit the full table name. The slowness issue was due to
ignoreAccentsbeing set to true (details here: JedWatson/react-select#3128). Datasource names should rarely have accented characters, so I think this is a fine fixBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Test and see much better performance
ADDITIONAL INFORMATION
REVIEWERS
@graceguo-supercat