Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update down_revision to fix migrations #7850

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Update down_revision to fix migrations #7850

merged 1 commit into from
Jul 11, 2019

Conversation

1AB9502
Copy link

@1AB9502 1AB9502 commented Jul 11, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

We forgot to update down_revision in #4725, so now the migrations have 2 heads.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@1AB9502
Copy link
Author

1AB9502 commented Jul 11, 2019

Looking into why travis is failing

@graceguo-supercat
Copy link

thanks for the quick fix. will merge after ci passed.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1AB9502
Copy link
Author

1AB9502 commented Jul 11, 2019

@graceguo-supercat ,

Thanks! 1 test is still failing, so I am looking into it now

@graceguo-supercat graceguo-supercat merged commit 9eccae3 into apache:master Jul 11, 2019
@graceguo-supercat
Copy link

don't worry about unit test failing...it's false alert from cypress. i will make a new PR for this issue.

alex-mark pushed a commit to alex-mark/incubator-superset that referenced this pull request Jul 29, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants