Persistent Dashboard refresh settings. #814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.02%) to 81.035% when pulling 6d9c45f2975f5e0daea2c9ceb8bd01e2aa4fd695 on alanmcruickshank:autorefresh-dashboard-4 into 2425b8f on airbnb:master. |
alanmcruickshank
force-pushed
the
autorefresh-dashboard-4
branch
from
6d9c45f
to
c912643
Compare
|
@mistercrunch I've rebased the changes up to the most recent master. I've noticed you've not merged this change in before, have you got questions/concerns about it? I'd love to get this into the next release, so let me know what you'd need to see for us to be able to do that. |
|
Sorry this never made it in, I'm cleaning up older PRs with merge conflicts at the moment. Please resubmit the PR if you want this feature to make it in. |
|
@alanmcruickshank was this one working? What was the impediment that prevented it from being merged? |
|
@dmigo It was working - but that was before at least one refactor of the dashboard (possibly many). I reckon some of this might still be salvageable but it would need some work. |
This was referenced Dec 19, 2020
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
Bumps [react-table](https://github.com/tannerlinsley/react-table) from 7.2.1 to 7.6.1. - [Release notes](https://github.com/tannerlinsley/react-table/releases) - [Changelog](https://github.com/tannerlinsley/react-table/blob/master/CHANGELOG.md) - [Commits](TanStack/table@v7.2.1...v7.6.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
Bumps [react-table](https://github.com/tannerlinsley/react-table) from 7.2.1 to 7.6.1. - [Release notes](https://github.com/tannerlinsley/react-table/releases) - [Changelog](https://github.com/tannerlinsley/react-table/blob/master/CHANGELOG.md) - [Commits](TanStack/table@v7.2.1...v7.6.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
Bumps [react-table](https://github.com/tannerlinsley/react-table) from 7.2.1 to 7.6.1. - [Release notes](https://github.com/tannerlinsley/react-table/releases) - [Changelog](https://github.com/tannerlinsley/react-table/blob/master/CHANGELOG.md) - [Commits](TanStack/table@v7.2.1...v7.6.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Bumps [react-table](https://github.com/tannerlinsley/react-table) from 7.2.1 to 7.6.1. - [Release notes](https://github.com/tannerlinsley/react-table/releases) - [Changelog](https://github.com/tannerlinsley/react-table/blob/master/CHANGELOG.md) - [Commits](TanStack/table@v7.2.1...v7.6.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revision of #718
Also resolves #686
Dashboard refresh settings persist and option to set whether to use cache or not when fetching fresh data.
Required a fix of migration 27ae655e4247 to avoid problems with referencing models which weren't up to date yet. Have moved to declarative base.
New pull request because the history of the previous one was getting really tangled.