Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[fix] make names non-nullable" #8363

Merged

Conversation

serenajiang
Copy link
Contributor

Reverts #8332

Some issue with foreign key constraints.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #8363 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8363   +/-   ##
=======================================
  Coverage   67.57%   67.57%           
=======================================
  Files         448      448           
  Lines       22527    22527           
  Branches     2364     2364           
=======================================
  Hits        15222    15222           
  Misses       7167     7167           
  Partials      138      138
Impacted Files Coverage Δ
superset/connectors/druid/models.py 82.41% <100%> (ø) ⬆️
superset/connectors/sqla/models.py 84.96% <100%> (ø) ⬆️
superset/models/core.py 81.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b85a8f...0697f7e. Read the comment docs.

@villebro
Copy link
Member

villebro commented Oct 9, 2019

Was this fundamentally the wrong solution, or is it just a bug in the PR? Feels like fixing the problem would be a better solution than reverting..

@serenajiang
Copy link
Contributor Author

Just a bug in the PR - I'll fix the problem soon, but this is breaking deploys, so for now, it might be better to revert it just to keep things consistent.

@villebro
Copy link
Member

villebro commented Oct 9, 2019

gotcha 👍

@etr2460 etr2460 merged commit 7e7ea3d into apache:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants