[SIP-36] Migrate setupApp.js to setupApp.ts

[etr2460]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

This is an example PR for migrating a JS file to TS. I performed the following steps:

1. Rename the file from setupApp.js => setupApp.ts
2. Install typedefs for imported libraries (ex npm install @types/jquery or add // @ts-ignore if no valid typedefs exist
3. Type function arguments to their expected values
4. Address all eslint warnings and errors

TEST PLAN

CI, confirm that previous behavior is still correct. In this case, check changing locales still works and that checkboxes work in CRUD Views

ADDITIONAL INFORMATION

• Has associated issue: [SIP-36] Proposal for standardizing use of TypeScript #9101
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

to: @nytai @graceguo-supercat @kristw @rusackas

[codecov-io]

Codecov Report

Merging #9180 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #9180      +/-   ##
=========================================
- Coverage   59.13%   59.1%   -0.03%     
=========================================
  Files         372     372              
  Lines       11938   11943       +5     
  Branches     2925    2925              
=========================================
  Hits         7059    7059              
- Misses       4699    4706       +7     
+ Partials      180     178       -2

Impacted Files	Coverage Δ
superset-frontend/src/setup/setupApp.ts	0% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74423e5...07d6b7e. Read the comment docs.

[graceguo-supercat]

Since you are making migration to ts, could you add unit test for every new component? The overall test coverage seems keep going down.

[etr2460]

That's a good point, any thoughts about how to test this file? The dependence on jquery makes me a bit uncertain about how to test....

[graceguo-supercat]

i want to remove jQuery usage from superset-frontend... is it possible? https://www.sitepoint.com/jquery-document-ready-plain-javascript/

[nytai]

I reimplemented the menu in react, so it's possible to fully deprecate jquery. The react menu hasn't been propagated to all the pages, yet. I was hoping to progressively roll it out by replacing all the server rendered pages, however if someone wants to speed up jquery deprecation that's available.

[nytai]

lgtm, +1 on jquery deprecation

[etr2460]

++ on jquery removal as well. I don't think that's in scope for this PR though...