fix: choose language link for local dev #9215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
@superset-ui/connection will add protocol and host to an "endpoint" call.
e.currentTarget.href
may return the full URL instead of the relative url. This sometimes results in invalid URLs for change language API calls.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
In local dev environment, change language will result in a 404 error:
The result should be gone after this fix.
TEST PLAN
Change language in local dev box will work and should not throw an error in the browser console.
ADDITIONAL INFORMATION
N/A
REVIEWERS
@kristw